Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3465)

Unified Diff: chrome/browser/ui/sync/one_click_signin_sync_starter.cc

Issue 485073002: Migrate signin error messages to the new avatar bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixed cros error Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_sync_starter.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
index de6db90f27f875ec1efb66650b52adf0d26ef344..1c262ece63f8e148494140e3e136cf5aaec82825 100644
--- a/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
+++ b/chrome/browser/ui/sync/one_click_signin_sync_starter.cc
@@ -488,22 +488,8 @@ void OneClickSigninSyncStarter::MergeSessionComplete(
void OneClickSigninSyncStarter::DisplayFinalConfirmationBubble(
const base::string16& custom_message) {
browser_ = EnsureBrowser(browser_, profile_, desktop_type_);
- // Show the success confirmation message in the new avatar menu if it is
- // enabled.
- // TODO(guohui): needs to handle custom messages.
- if (custom_message.empty() && switches::IsNewAvatarMenu()) {
- browser_->window()->ShowAvatarBubbleFromAvatarButton(
- BrowserWindow::AVATAR_BUBBLE_MODE_CONFIRM_SIGNIN,
- signin::ManageAccountsParams());
- return;
- }
-
- browser_->window()->ShowOneClickSigninBubble(
- BrowserWindow::ONE_CLICK_SIGNIN_BUBBLE_TYPE_BUBBLE,
- base::string16(), // No email required - this is not a SAML confirmation.
- custom_message,
- // Callback is ignored.
- BrowserWindow::StartSyncCallback());
+ LoginUIServiceFactory::GetForProfile(browser_->profile())->
+ DisplayLoginResult(browser_, custom_message);
}
// static
« no previous file with comments | « chrome/browser/ui/sync/one_click_signin_helper.cc ('k') | chrome/browser/ui/views/profiles/profile_chooser_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698