chrome/browser/signin/signin_ui_util.h - Issue 485073002: Migrate signin error messages to the new avatar bubble

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/signin/signin_ui_util.h

Issue 485073002: Migrate signin error messages to the new avatar bubble (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mac compiler error fixed Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/profiles/profile_window.cc ('k') | chrome/browser/signin/signin_ui_util.cc » ('j') | chrome/browser/signin/signin_ui_util.cc » ('J')

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SIGNIN_SIGNIN_UI_UTIL_H_	5 #ifndef CHROME_BROWSER_SIGNIN_SIGNIN_UI_UTIL_H_

6 #define CHROME_BROWSER_SIGNIN_SIGNIN_UI_UTIL_H_	6 #define CHROME_BROWSER_SIGNIN_SIGNIN_UI_UTIL_H_

7	7

8 #include <vector>	8 #include <vector>

9	9

10 #include "base/strings/string16.h"	10 #include "base/strings/string16.h"

(...skipping 20 matching lines...) Expand all Loading...
31 // "Sign in to Chromium", "Signin Error...", etc).	31 // "Sign in to Chromium", "Signin Error...", etc).

32 base::string16 GetSigninMenuLabel(Profile* profile);	32 base::string16 GetSigninMenuLabel(Profile* profile);

33	33

34 void GetStatusLabelsForAuthError(Profile* profile,	34 void GetStatusLabelsForAuthError(Profile* profile,

35 const SigninManagerBase& signin_manager,	35 const SigninManagerBase& signin_manager,

36 base::string16* status_label,	36 base::string16* status_label,

37 base::string16* link_label);	37 base::string16* link_label);

38	38

39 void InitializePrefsForProfile(Profile* profile);	39 void InitializePrefsForProfile(Profile* profile);

40	40

	41 void ShowSigninErrorLearnMorePage(Profile* profile);
	Alexei Svitkine (slow) 2014/08/19 20:09:00 Nit: It would be good to have comments for these m Nit: It would be good to have comments for these methods. guohui 2014/08/19 20:26:31 Done. Show quoted text On 2014/08/19 20:09:00, Alexei Svitkine wrote: > Nit: It would be good to have comments for these methods. Done.
	42

41 } // namespace signin_ui_util	43 } // namespace signin_ui_util

42	44

43 #endif // CHROME_BROWSER_SIGNIN_SIGNIN_UI_UTIL_H_	45 #endif // CHROME_BROWSER_SIGNIN_SIGNIN_UI_UTIL_H_

OLD	NEW