Issue 485053002: Account for MathML tags / attributes in staticQualifiedNamesCount

Issue 485053002: Account for MathML tags / attributes in staticQualifiedNamesCount (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
adamk, eseidel

CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, pilgrim_google, rwlbuis, sof, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Account for MathML tags / attributes in staticQualifiedNamesCount Account for MathML tags / attributes in staticQualifiedNamesCount in QualifiedName.cpp. This code was removed in r149242 when MathML support was partially removed. However, MathMLNames.h is still generated and used in the code base so we should still account for those static QualifiedNames. This avoids unnecessary hash table expansion and rehashing due to minimumTableSize HashTraits variable being inaccurate. R=eseidel@chromium.org, adamk@chromium.org BUG=236462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180587

Patch Set 1 #

Patch Set 2 : Sort alphabetically #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	Source/core/dom/QualifiedName.cpp	View	1	2 chunks	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/485053002/20001

6 years, 4 months ago (2014-08-19 17:59:57 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (20001) as 180587

6 years, 4 months ago (2014-08-19 18:04:15 UTC) #5

eseidel

6 years, 4 months ago (2014-08-20 17:06:23 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/485053002/diff/20001/Source/core/dom/Qualifie...
File Source/core/dom/QualifiedName.cpp (right):

https://codereview.chromium.org/485053002/diff/20001/Source/core/dom/Qualifie...
Source/core/dom/QualifiedName.cpp:38: + MathMLNames::MathMLTagsCount +
MathMLNames::MathMLAttrsCount
This seems pretty brittle.  Can we add an ASSERT somewhere to make sure these
are all counted?  Or make these counted apart of the ::init() process?

Expand Messages | Collapse Messages