Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: cc/trees/blocking_task_runner.cc

Issue 485043003: cc: Use correct message loop proxy in BlockingTaskRunner (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/blocking_task_runner.h" 5 #include "cc/trees/blocking_task_runner.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/callback.h"
9 #include "base/logging.h" 10 #include "base/logging.h"
10 #include "base/memory/singleton.h"
11 #include "base/message_loop/message_loop_proxy.h" 11 #include "base/message_loop/message_loop_proxy.h"
12 12
13 namespace cc { 13 namespace cc {
14 14
15 struct TaskRunnerPairs {
16 static TaskRunnerPairs* GetInstance() {
17 return Singleton<TaskRunnerPairs>::get();
18 }
19
20 base::Lock lock;
21 std::vector<scoped_refptr<BlockingTaskRunner> > runners;
22
23 private:
24 friend struct DefaultSingletonTraits<TaskRunnerPairs>;
25 };
26
27 // static 15 // static
28 scoped_refptr<BlockingTaskRunner> BlockingTaskRunner::current() { 16 scoped_ptr<BlockingTaskRunner> BlockingTaskRunner::Create(
29 TaskRunnerPairs* task_runners = TaskRunnerPairs::GetInstance(); 17 scoped_refptr<base::SingleThreadTaskRunner> task_runner) {
30 base::PlatformThreadId thread_id = base::PlatformThread::CurrentId(); 18 return make_scoped_ptr(new BlockingTaskRunner(task_runner));
31
32 base::AutoLock lock(task_runners->lock);
33
34 scoped_refptr<BlockingTaskRunner> current_task_runner;
35
36 for (size_t i = 0; i < task_runners->runners.size(); ++i) {
37 if (task_runners->runners[i]->thread_id_ == thread_id) {
38 current_task_runner = task_runners->runners[i];
39 } else if (task_runners->runners[i]->HasOneRef()) {
40 task_runners->runners.erase(task_runners->runners.begin() + i);
41 i--;
42 }
43 }
44
45 if (current_task_runner.get())
46 return current_task_runner;
47
48 scoped_refptr<BlockingTaskRunner> runner =
49 new BlockingTaskRunner(base::MessageLoopProxy::current());
50 task_runners->runners.push_back(runner);
51 return runner;
52 } 19 }
53 20
54 BlockingTaskRunner::BlockingTaskRunner( 21 BlockingTaskRunner::BlockingTaskRunner(
55 scoped_refptr<base::SingleThreadTaskRunner> task_runner) 22 scoped_refptr<base::SingleThreadTaskRunner> task_runner)
56 : thread_id_(base::PlatformThread::CurrentId()), 23 : task_runner_(task_runner), capture_(0) {
57 task_runner_(task_runner),
58 capture_(0) {
59 } 24 }
60 25
61 BlockingTaskRunner::~BlockingTaskRunner() {} 26 BlockingTaskRunner::~BlockingTaskRunner() {}
62 27
63 bool BlockingTaskRunner::BelongsToCurrentThread() { 28 bool BlockingTaskRunner::BelongsToCurrentThread() {
64 return base::PlatformThread::CurrentId() == thread_id_; 29 return task_runner_ ? task_runner_->BelongsToCurrentThread() : true;
65 } 30 }
66 31
67 bool BlockingTaskRunner::PostTask(const tracked_objects::Location& from_here, 32 bool BlockingTaskRunner::PostTask(const tracked_objects::Location& from_here,
68 const base::Closure& task) { 33 const base::Closure& task) {
69 base::AutoLock lock(lock_); 34 base::AutoLock lock(lock_);
70 DCHECK(task_runner_.get() || capture_); 35 DCHECK(task_runner_.get() || capture_);
71 if (!capture_) 36 if (!capture_)
72 return task_runner_->PostTask(from_here, task); 37 return task_runner_->PostTask(from_here, task);
73 captured_tasks_.push_back(task); 38 captured_tasks_.push_back(task);
74 return true; 39 return true;
(...skipping 12 matching lines...) Expand all
87 if (capture_) 52 if (capture_)
88 return; 53 return;
89 54
90 // We're done capturing, so grab all the captured tasks and run them. 55 // We're done capturing, so grab all the captured tasks and run them.
91 tasks.swap(captured_tasks_); 56 tasks.swap(captured_tasks_);
92 } 57 }
93 for (size_t i = 0; i < tasks.size(); ++i) 58 for (size_t i = 0; i < tasks.size(); ++i)
94 tasks[i].Run(); 59 tasks[i].Run();
95 } 60 }
96 61
97 BlockingTaskRunner::CapturePostTasks::CapturePostTasks() 62 BlockingTaskRunner::CapturePostTasks::CapturePostTasks(
98 : blocking_runner_(BlockingTaskRunner::current()) { 63 BlockingTaskRunner* blocking_runner)
64 : blocking_runner_(blocking_runner) {
99 blocking_runner_->SetCapture(true); 65 blocking_runner_->SetCapture(true);
100 } 66 }
101 67
102 BlockingTaskRunner::CapturePostTasks::~CapturePostTasks() { 68 BlockingTaskRunner::CapturePostTasks::~CapturePostTasks() {
103 blocking_runner_->SetCapture(false); 69 blocking_runner_->SetCapture(false);
104 } 70 }
105 71
106 } // namespace cc 72 } // namespace cc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698