Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: runtime/lib/array_patch.dart

Issue 485043002: Optimize List.toList/.sublist and List.from on lists. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Avoid calling _GrowableList.withData with empty list. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // The _GrowableArrayMarker class is used to signal to the List() factory 5 // The _GrowableArrayMarker class is used to signal to the List() factory
6 // whether a parameter was passed. 6 // whether a parameter was passed.
7 class _GrowableArrayMarker implements int { 7 class _GrowableArrayMarker implements int {
8 const _GrowableArrayMarker(); 8 const _GrowableArrayMarker();
9 } 9 }
10 10
(...skipping 14 matching lines...) Expand all
25 // of new _List. 25 // of new _List.
26 var result = new _List<E>(length); 26 var result = new _List<E>(length);
27 if (fill != null) { 27 if (fill != null) {
28 for (int i = 0; i < length; i++) { 28 for (int i = 0; i < length; i++) {
29 result[i] = fill; 29 result[i] = fill;
30 } 30 }
31 } 31 }
32 return result; 32 return result;
33 } 33 }
34 34
35 /* patch */ factory List.from(Iterable other, { bool growable: true }) {
36 if (other is EfficientLength) {
37 int length = other.length;
38 var list = growable ? new _GrowableList<E>(length) : new _List<E>(length);
39 int i = 0;
40 for (var element in other) { list[i++] = element; }
41 return list;
42 }
43 List<E> list = new _GrowableList<E>(0);
44 for (E e in other) {
45 list.add(e);
46 }
47 if (growable) return list;
48 return makeListFixedLength(list);
49 }
50
35 // Factory constructing a mutable List from a parser generated List literal. 51 // Factory constructing a mutable List from a parser generated List literal.
36 // [elements] contains elements that are already type checked. 52 // [elements] contains elements that are already type checked.
37 factory List._fromLiteral(List elements) { 53 factory List._fromLiteral(List elements) {
38 if (elements.isEmpty) { 54 if (elements.isEmpty) {
39 return new _GrowableList<E>(0); 55 return new _GrowableList<E>(0);
40 } 56 }
41 var result = new _GrowableList<E>.withData(elements); 57 var result = new _GrowableList<E>.withData(elements);
42 result._setLength(elements.length); 58 result._setLength(elements.length);
43 return result; 59 return result;
44 } 60 }
45 } 61 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698