Issue 485003004: [Telemetry] Chrome OS gathers power and time in one command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 485003004: [Telemetry] Chrome OS gathers power and time in one command. (Closed)

Created:
6 years, 4 months ago by tmandel

Modified:
6 years, 4 months ago

Reviewers:
dbasehore, tbroch1, tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Telemetry] Chrome OS gathers power and time in one command. In order to ensure that the time of each sample is as accurate as possible to report valid power usage, gather time and power as a single shell command instead of two. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291544

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -7 lines)			Patch
	M	tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor.py	View		2 chunks	+25 lines, -7 lines	0 comments	Download
	M	tools/telemetry/telemetry/core/platform/power_monitor/cros_power_monitor_unittest.py	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tmandel

A small change to CrOS monitoring to make sure the length of the power sample ...

6 years, 4 months ago (2014-08-22 21:00:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmandel@chromium.org/485003004/1

6 years, 4 months ago (2014-08-22 21:04:57 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...

6 years, 4 months ago (2014-08-22 22:06:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (1) as 291544

Expand Messages | Collapse Messages