Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 484983003: Mojo: Fix warnings when generating code for empty struct in java. (Closed)

Created:
6 years, 4 months ago by qsr
Modified:
6 years, 4 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Fix warnings when generating code for empty struct in java. BUG=404873 R=ppi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290579

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/BindingsTest.java View 2 chunks +12 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qsr
6 years, 4 months ago (2014-08-19 07:51:17 UTC) #1
ppi
lgtm https://codereview.chromium.org/484983003/diff/1/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl File mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl (right): https://codereview.chromium.org/484983003/diff/1/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl#newcode81 mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl:81: {% if struct.bytes|length == 0 %} nit: would ...
6 years, 4 months ago (2014-08-19 11:04:51 UTC) #2
qsr
https://codereview.chromium.org/484983003/diff/1/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl File mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl (right): https://codereview.chromium.org/484983003/diff/1/mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl#newcode81 mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl:81: {% if struct.bytes|length == 0 %} On 2014/08/19 11:04:51, ...
6 years, 4 months ago (2014-08-19 11:13:03 UTC) #3
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 4 months ago (2014-08-19 11:13:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/484983003/20001
6 years, 4 months ago (2014-08-19 11:14:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-19 12:55:21 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 16:11:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290579

Powered by Google App Engine
This is Rietveld 408576698