Issue 484953003: Revert "[arm] Shorter test names for parameterized tests."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 484953003: Revert "[arm] Shorter test names for parameterized tests." (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Jarin

CC:
Rodolph Perfetta (ARM), v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "[arm] Shorter test names for parameterized tests." This reverts commit r23142 because GoogleTest is very picky about the parameterized test case names, so not even using an anonymous namespace can please GTest. Also reverts the renaming applied to in the ChangeLowering unit test. TBR=jarin@chromium.org BUG=v8:3489 LOG=n Committed: https://code.google.com/p/v8/source/detail?r=23177

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -68 lines)			Patch
	M	test/compiler-unittests/arm/instruction-selector-arm-unittest.cc	View		41 chunks	+44 lines, -57 lines	0 comments	Download
	M	test/compiler-unittests/change-lowering-unittest.cc	View		5 chunks	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 4 months ago (2014-08-19 05:24:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 23177 (tree was closed).

Expand Messages | Collapse Messages