Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: ui/gfx/render_text.cc

Issue 484883003: Re-land: RenderTextHarfBuzz: Set font render parameters in font data functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/render_text.cc
diff --git a/ui/gfx/render_text.cc b/ui/gfx/render_text.cc
index 807f8cd12ebe8d5b2579c25df00b65947789bc13..81448d057ef37788480c7650bcb4f4845bd770ba 100644
--- a/ui/gfx/render_text.cc
+++ b/ui/gfx/render_text.cc
@@ -213,12 +213,7 @@ void SkiaTextRenderer::SetDrawLooper(SkDrawLooper* draw_looper) {
void SkiaTextRenderer::SetFontRenderParams(const FontRenderParams& params,
bool background_is_transparent) {
- paint_.setAntiAlias(params.antialiasing);
- paint_.setLCDRenderText(!background_is_transparent &&
- params.subpixel_rendering != FontRenderParams::SUBPIXEL_RENDERING_NONE);
- paint_.setSubpixelText(params.subpixel_positioning);
- paint_.setAutohinted(params.autohinter);
- paint_.setHinting(FontRenderParamsHintingToSkPaintHinting(params.hinting));
+ ApplyRenderParams(params, background_is_transparent, &paint_);
}
void SkiaTextRenderer::SetTypeface(SkTypeface* typeface) {
@@ -416,6 +411,17 @@ skia::RefPtr<SkTypeface> CreateSkiaTypeface(const std::string& family,
return skia::AdoptRef(SkTypeface::CreateFromName(family.c_str(), skia_style));
}
+void ApplyRenderParams(const FontRenderParams& params,
+ bool background_is_transparent,
+ SkPaint* paint) {
+ paint->setAntiAlias(params.antialiasing);
+ paint->setLCDRenderText(!background_is_transparent &&
+ params.subpixel_rendering != FontRenderParams::SUBPIXEL_RENDERING_NONE);
+ paint->setSubpixelText(params.subpixel_positioning);
+ paint->setAutohinted(params.autohinter);
+ paint->setHinting(FontRenderParamsHintingToSkPaintHinting(params.hinting));
+}
+
} // namespace internal
RenderText::~RenderText() {

Powered by Google App Engine
This is Rietveld 408576698