Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: ui/gfx/font_render_params_mac.cc

Issue 484883003: Re-land: RenderTextHarfBuzz: Set font render parameters in font data functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/font_render_params_mac.cc
diff --git a/ui/gfx/font_render_params_android.cc b/ui/gfx/font_render_params_mac.cc
similarity index 56%
copy from ui/gfx/font_render_params_android.cc
copy to ui/gfx/font_render_params_mac.cc
index c5b17b0304f1a76a8731295a09632cf5cede3737..7aa40380223243285956b9b9d21009f47a12a15d 100644
--- a/ui/gfx/font_render_params_android.cc
+++ b/ui/gfx/font_render_params_mac.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -11,19 +11,15 @@ namespace gfx {
namespace {
-// Returns the system's default settings.
+// Returns params that match SkiaTextRenderer's default render settings.
FontRenderParams LoadDefaults() {
FontRenderParams params;
params.antialiasing = true;
- params.autohinter = true;
+ params.autohinter = false;
params.use_bitmaps = true;
- params.subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_NONE;
-
- // Use subpixel text positioning to keep consistent character spacing when
- // the page is scaled by a fractional factor.
+ params.subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_RGB;
params.subpixel_positioning = true;
- // Slight hinting renders much better than normal hinting on Android.
- params.hinting = FontRenderParams::HINTING_SLIGHT;
+ params.hinting = FontRenderParams::HINTING_MEDIUM;
return params;
}
@@ -32,11 +28,10 @@ FontRenderParams LoadDefaults() {
FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
std::string* family_out) {
- // Customized font rendering settings are not supported, only defaults.
+ // Customized font rendering settings are not yet implemented.
if (!query.is_empty() || family_out)
NOTIMPLEMENTED();
- CR_DEFINE_STATIC_LOCAL(
- const gfx::FontRenderParams, params, (LoadDefaults()));
+ CR_DEFINE_STATIC_LOCAL(const gfx::FontRenderParams, params, (LoadDefaults()));
return params;
}

Powered by Google App Engine
This is Rietveld 408576698