Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Unified Diff: ui/gfx/font_render_params_win.cc

Issue 484883003: Re-land: RenderTextHarfBuzz: Set font render parameters in font data functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment fixed Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/font_render_params_mac.cc ('k') | ui/gfx/gfx.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/font_render_params_win.cc
diff --git a/ui/gfx/font_render_params_win.cc b/ui/gfx/font_render_params_win.cc
index 2ad1b5bf42c94d622fa4f845ca4218472643c428..a6fc6186cdd2bad20e35654c2acf7a8396828faa 100644
--- a/ui/gfx/font_render_params_win.cc
+++ b/ui/gfx/font_render_params_win.cc
@@ -19,7 +19,7 @@ class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {
return Singleton<CachedFontRenderParams>::get();
}
- const FontRenderParams& GetParams() {
+ const FontRenderParams& GetParams(bool for_web_contents) {
if (params_)
return *params_;
@@ -34,7 +34,8 @@ class CachedFontRenderParams : public gfx::SingletonHwnd::Observer {
BOOL enabled = false;
if (SystemParametersInfo(SPI_GETFONTSMOOTHING, 0, &enabled, 0) && enabled) {
params_->antialiasing = true;
- params_->subpixel_positioning = true;
+ // Subpixel positioning is not yet implemented for UI. crbug.com/389649
+ params_->subpixel_positioning = for_web_contents;
UINT type = 0;
if (SystemParametersInfo(SPI_GETFONTSMOOTHINGTYPE, 0, &type, 0) &&
@@ -77,7 +78,8 @@ FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
// Customized font rendering settings are not supported, only defaults.
if (!query.is_empty() || family_out)
NOTIMPLEMENTED();
- return CachedFontRenderParams::GetInstance()->GetParams();
+ return CachedFontRenderParams::GetInstance()->GetParams(
+ query.for_web_contents);
}
} // namespace gfx
« no previous file with comments | « ui/gfx/font_render_params_mac.cc ('k') | ui/gfx/gfx.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698