Re-land: RenderTextHarfBuzz: Set font render parameters in font data functions

ui/gfx/font_render_params_mac.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/font_render_params.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 
 namespace gfx {
 
 namespace {
 
-// Returns the system's default settings.
+// Returns params that match SkiaTextRenderer's default render settings.
 FontRenderParams LoadDefaults() {
   FontRenderParams params;
   params.antialiasing = true;
-  params.autohinter = true;
+  params.autohinter = false;
   params.use_bitmaps = true;
-  params.subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_NONE;
-
-  // Use subpixel text positioning to keep consistent character spacing when
-  // the page is scaled by a fractional factor.
+  params.subpixel_rendering = FontRenderParams::SUBPIXEL_RENDERING_RGB;
   params.subpixel_positioning = true;
-  // Slight hinting renders much better than normal hinting on Android.
-  params.hinting = FontRenderParams::HINTING_SLIGHT;
+  params.hinting = FontRenderParams::HINTING_MEDIUM;
 
   return params;
 }
 
 }  // namespace
 
 FontRenderParams GetFontRenderParams(const FontRenderParamsQuery& query,
                                      std::string* family_out) {
-  // Customized font rendering settings are not supported, only defaults.
+  // Customized font rendering settings are not yet implemented.

[Daniel Erat, 2014/08/25 18:27:12]

do macs support per-family/size/style customization of rendering settings? if
not, this comment doesn't seem accurate.

[ckocagil, 2014/08/25 20:49:12]

I don't know. I changed to comment, it should be better now.

   if (!query.is_empty() || family_out)
     NOTIMPLEMENTED();
-  CR_DEFINE_STATIC_LOCAL(
-      const gfx::FontRenderParams, params, (LoadDefaults()));
+  CR_DEFINE_STATIC_LOCAL(const gfx::FontRenderParams, params, (LoadDefaults()));
   return params;
 }
 
 }  // namespace gfx