Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 484873004: athena: Add support for PDF (Closed)

Created:
6 years, 4 months ago by sadrul
Modified:
6 years, 3 months ago
Reviewers:
oshima, James Cook, raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

athena: Add support for PDF. Advertise support for PDF plugins, and use the implementations from the pdf component (in //components/pdf) for adding the necessary support for showing PDF files in athena. BUG=401242 R=jamescook@chromium.org, oshima@chromium.org, raymes@chromium.org Committed: https://crrev.com/8d7df02b9f6ac93a1f0383ff06af82de5c6813ee Cr-Commit-Position: refs/heads/master@{#292684}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : v8 for win #

Patch Set 11 : fix-win #

Patch Set 12 : fix-win #

Patch Set 13 : tot-merge #

Patch Set 14 : namespace #

Patch Set 15 : tot-merge #

Patch Set 16 : tot.merge #

Patch Set 17 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -1 line) Patch
M athena/main/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +5 lines, -0 lines 0 comments Download
A athena/main/athena_content_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +27 lines, -0 lines 0 comments Download
A athena/main/athena_content_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +52 lines, -0 lines 0 comments Download
M athena/main/athena_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +35 lines, -0 lines 0 comments Download
M athena/main/athena_main.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 3 chunks +7 lines, -1 line 0 comments Download
A athena/main/athena_renderer_pdf_helper.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +27 lines, -0 lines 0 comments Download
A athena/main/athena_renderer_pdf_helper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
sadrul
sadrul@chromium.org changed reviewers: + jamescook@chormium.org, oshima@chromium.org, raymes@chromium.org
6 years, 3 months ago (2014-08-28 23:07:45 UTC) #1
sadrul
oshima@ all changes jamescook@ all changes + owner for DEPS addition to extensions/shell/common raymes@ owner ...
6 years, 3 months ago (2014-08-28 23:07:45 UTC) #2
raymes
On 2014/08/28 23:07:45, sadrul wrote: > oshima@ all changes > > jamescook@ all changes + ...
6 years, 3 months ago (2014-08-29 01:16:54 UTC) #3
oshima
we may want to restructure the dir/code for main/app_shell, but lgtm for now.
6 years, 3 months ago (2014-08-29 18:00:07 UTC) #4
James Cook
lgtm
6 years, 3 months ago (2014-08-29 21:21:38 UTC) #6
sadrul
Committed patchset #17 (id:320001) manually as 8d7df02 (presubmit successful).
6 years, 3 months ago (2014-08-29 21:33:36 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:36 UTC) #8
Message was sent while issue was closed.
Patchset 17 (id:??) landed as
https://crrev.com/8d7df02b9f6ac93a1f0383ff06af82de5c6813ee
Cr-Commit-Position: refs/heads/master@{#292684}

Powered by Google App Engine
This is Rietveld 408576698