Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 484853004: Improving copresence request logging (Closed)

Created:
6 years, 4 months ago by Charlie
Modified:
6 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, rkc
Base URL:
https://chromium.googlesource.com/chromium/src.git@hack
Project:
chromium
Visibility:
Public.

Description

Improving copresence request logging Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M components/copresence/rpc/http_post.h View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/rpc/http_post.cc View 5 chunks +10 lines, -3 lines 0 comments Download
M components/copresence/rpc/http_post_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Charlie
6 years, 4 months ago (2014-08-19 00:23:37 UTC) #1
xiyuan
lgtm
6 years, 4 months ago (2014-08-19 00:26:29 UTC) #2
Charlie
The CQ bit was checked by ckehoe@chromium.org
6 years, 4 months ago (2014-08-19 17:58:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ckehoe@chromium.org/484853004/1
6 years, 4 months ago (2014-08-19 17:59:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-19 19:21:53 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 19:57:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 290639

Powered by Google App Engine
This is Rietveld 408576698