pkg/analysis_server/tool/spec/codegen_java.dart - Issue 484833003: Change type boolean to Boolean in Java generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/tool/spec/codegen_java.dart

Issue 484833003: Change type boolean to Boolean in Java generated code (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/tool/spec/codegen_java.dart

diff --git a/pkg/analysis_server/tool/spec/codegen_java.dart b/pkg/analysis_server/tool/spec/codegen_java.dart

index 45f812667d06051880ac65977af4a442ccc3f240..b1e07c1a2895537d213ea6dbee2f14dd06ff8169 100644

--- a/pkg/analysis_server/tool/spec/codegen_java.dart

+++ b/pkg/analysis_server/tool/spec/codegen_java.dart

@@ -31,7 +31,9 @@ class CodegenJavaVisitor extends HierarchicalApiVisitor with CodeGenerator {

* Type references in the spec that are named something else in Java.

static const Map<String, String> _typeRenames = const {

- 'bool': 'boolean',

+ // TODO (jwren) in some situations we want to use Boolean while other

+ // situations we want to use boolean...

+ 'bool': 'Boolean',

'FilePath': 'String',

'DebugContextId': 'String',

'object': 'Object',

« no previous file with comments | « editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java ('k') | no next file » | no next file with comments »