Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/unittest/lib/src/test_case.dart

Issue 48483002: Remove deprecated parts of dart:async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address Bob's comment. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/pkg.status ('K') | « pkg/unittest/lib/src/future_matchers.dart ('k') | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/src/test_case.dart
diff --git a/pkg/unittest/lib/src/test_case.dart b/pkg/unittest/lib/src/test_case.dart
index e1d38750e3bbf15b1227df1e0b825eb0bcfb9342..1dc4264c4e22500fbdd30149bfe3ddc77b97db5f 100644
--- a/pkg/unittest/lib/src/test_case.dart
+++ b/pkg/unittest/lib/src/test_case.dart
@@ -70,14 +70,10 @@ class TestCase {
bool get isComplete => !enabled || result != null;
- Function _errorHandler(String stage) => (e) {
+ Function _errorHandler(String stage) => (e, stack) {
var stack;
- // TODO(kevmoo): Ideally, getAttachedStackTrace should handle Error as well?
- // https://code.google.com/p/dart/issues/detail?id=12240
- if(e is Error) {
+ if (stack == null && e is Error) {
stack = e.stackTrace;
- } else {
- stack = getAttachedStackTrace(e);
}
if (result == null || result == PASS) {
if (e is TestFailure) {
« pkg/pkg.status ('K') | « pkg/unittest/lib/src/future_matchers.dart ('k') | sdk/lib/_internal/compiler/implementation/compiler.dart » ('j') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698