Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/unittest/lib/src/core_matchers.dart

Issue 48483002: Remove deprecated parts of dart:async. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address Bob's comment. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/pkg.status ('K') | « pkg/scheduled_test/lib/src/schedule_error.dart ('k') | pkg/unittest/lib/src/future_matchers.dart » ('j') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/src/core_matchers.dart
diff --git a/pkg/unittest/lib/src/core_matchers.dart b/pkg/unittest/lib/src/core_matchers.dart
index b9bde13434452e5779b343d8fedf1f2621815255..e120c9e80acfe2d5b6637d470837b4d9b91ad750 100644
--- a/pkg/unittest/lib/src/core_matchers.dart
+++ b/pkg/unittest/lib/src/core_matchers.dart
@@ -418,11 +418,10 @@ class Throws extends Matcher {
// completes.
item.then((value) {
done(() => fail("Expected future to fail, but succeeded with '$value'."));
- }, onError: (error) {
+ }, onError: (error, trace) {
done(() {
if (_matcher == null) return;
var reason;
- var trace = getAttachedStackTrace(error);
if (trace != null) {
var stackTrace = trace.toString();
stackTrace = " ${stackTrace.replaceAll("\n", "\n ")}";
« pkg/pkg.status ('K') | « pkg/scheduled_test/lib/src/schedule_error.dart ('k') | pkg/unittest/lib/src/future_matchers.dart » ('j') | sdk/lib/_internal/pub/lib/src/barback/server.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698