Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 484813002: Add support for prebuilt jars (Closed)

Created:
6 years, 4 months ago by cjhopman
Modified:
6 years, 4 months ago
Reviewers:
brettw, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-lint
Project:
chromium
Visibility:
Public.

Description

Add support for prebuilt jars Mostly just a refactoring of build rules to support prebuilt jars. Adds support for proguard preprocessing of both prebuilt and non-prebuilt java libraries. Adds definitions of all (but for android.jar) of the prebuilt jars that we need from the sdk. BUG=359249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291464

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -62 lines) Patch
M BUILD.gn View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M build/android/gyp/proguard.py View 3 chunks +15 lines, -5 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 5 chunks +118 lines, -56 lines 0 comments Download
M build/config/android/rules.gni View 1 2 3 chunks +74 lines, -0 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 2 chunks +46 lines, -0 lines 0 comments Download
M third_party/guava/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
cjhopman
newt: *
6 years, 4 months ago (2014-08-18 20:50:02 UTC) #1
newt (away)
lgtm nit then lgtm https://codereview.chromium.org/484813002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/484813002/diff/1/build/config/android/rules.gni#newcode405 build/config/android/rules.gni:405: # proguard_preprocess: If true, proguard ...
6 years, 4 months ago (2014-08-18 21:08:44 UTC) #2
cjhopman
https://codereview.chromium.org/484813002/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/484813002/diff/1/build/config/android/rules.gni#newcode405 build/config/android/rules.gni:405: # proguard_preprocess: If true, proguard preprocessing will be run. ...
6 years, 4 months ago (2014-08-18 21:28:27 UTC) #3
cjhopman
brettw for OWNERS
6 years, 4 months ago (2014-08-18 21:29:16 UTC) #4
cjhopman
ping
6 years, 4 months ago (2014-08-20 21:45:20 UTC) #5
brettw
rs lgtm https://codereview.chromium.org/484813002/diff/20001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/484813002/diff/20001/build/config/android/internal_rules.gni#newcode365 build/config/android/internal_rules.gni:365: sources = [_input_jar_path] I've been doing spaces ...
6 years, 4 months ago (2014-08-20 22:24:02 UTC) #6
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 4 months ago (2014-08-22 01:18:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/484813002/40001
6 years, 4 months ago (2014-08-22 01:19:51 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 02:14:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 02:17:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8341)
6 years, 4 months ago (2014-08-22 02:17:40 UTC) #11
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 4 months ago (2014-08-22 18:07:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/484813002/40001
6 years, 4 months ago (2014-08-22 18:08:29 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 19:12:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (40001) as 291464

Powered by Google App Engine
This is Rietveld 408576698