Pepper: Report NaCl exit status over Chromium IPC.

components/nacl/loader/nacl_listener.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/nacl/loader/nacl_listener.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <stdlib.h>
 #include <string.h>
 
 #if defined(OS_POSIX)
 #include <unistd.h>
 #endif
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/rand_util.h"
 #include "components/nacl/common/nacl_messages.h"
+#include "components/nacl/common/nacl_renderer_messages.h"
 #include "components/nacl/loader/nacl_ipc_adapter.h"
 #include "components/nacl/loader/nacl_validation_db.h"
 #include "components/nacl/loader/nacl_validation_query.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_switches.h"
 #include "ipc/ipc_sync_channel.h"
 #include "ipc/ipc_sync_message_filter.h"
 #include "native_client/src/public/chrome_main.h"
 #include "native_client/src/public/nacl_app.h"
 #include "native_client/src/public/nacl_file_info.h"
@@ skipping 379 matching lines @@
                       _O_RDONLY | _O_BINARY);
 #elif defined(OS_POSIX)
   nexe_file_info.desc = nexe_file;
 #else
 #error Unsupported target platform.
 #endif
   nexe_file_info.file_token.lo = params.nexe_token_lo;
   nexe_file_info.file_token.hi = params.nexe_token_hi;
   args->nexe_desc = NaClDescIoFromFileInfo(nexe_file_info, NACL_ABI_O_RDONLY);
 
-  NaClChromeMainStartApp(nap, args);
+  int exit_status;
+  if (!NaClChromeMainStart(nap, args, &exit_status))
+    NaClExit(1);
+
+  // Report the plugin's exit status if the application started successfully.
+  // TODO(teravest): Use a separate is_helper_process field instead of assuming

[Mark Seaborn, 2014/08/21 21:12:32]

How about sending it unconditionally but having TrustedPluginChannel know
whether the message should be ignored or not?

[teravest, 2014/08/22 16:07:11]

Done.

+  // the translator doesn't use the IRT.
+  if (params.uses_irt)
+    trusted_listener_->Send(new NaClRendererMsg_ReportExitStatus(exit_status));
+  NaClExit(exit_status);
 }