Issue 484753002: Fix exception when running Sheriff-o-Matic tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 484753002: Fix exception when running Sheriff-o-Matic tests. (Closed)

Created:
6 years, 4 months ago by michaelpg

Modified:
6 years, 4 months ago

Reviewers:
ojan

CC:
ojan, blink-reviews, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Fix exception when running Sheriff-o-Matic tests. Exception is caused by embedded-flakiness-dashboard. The iframe needs to be added to the DOM to expose the contentWindow property. By adding captureConsole: true to karma.conf.js, we will also see these errors in the karma test runner in the future. BUG=404415 R=ojan@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180485

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	Tools/GardeningServer/karma.conf.js	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Tools/GardeningServer/ui/test/ct-commit-list-tests.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Tools/GardeningServer/ui/test/ct-results-panel-tests.html	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

michaelpg

The change to ct-commit-list-tests.html is necessary because somehow, adding a property to the Object prototype ...

6 years, 4 months ago (2014-08-18 18:26:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/484753002/1

6 years, 4 months ago (2014-08-18 19:06:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (1) as 180485

Expand Messages | Collapse Messages