Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 48473002: ARM: Replace branch with conditional store in function prologue. (Closed)

Created:
7 years, 1 month ago by Benedikt Meurer
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

ARM: Replace branch with conditional store in function prologue. Use conditional store to replace the receiver with undefined for strict mode functions and builtins instead of branching code. This has similar performance characteristics but saves one branch instruction per strict mode function. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17412

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Sven, This is a trivial optimization. PTAL -- Benedikt
7 years, 1 month ago (2013-10-28 10:17:14 UTC) #1
Sven Panne
lgtm
7 years, 1 month ago (2013-10-28 10:28:41 UTC) #2
Benedikt Meurer
7 years, 1 month ago (2013-10-28 10:30:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17412.

Powered by Google App Engine
This is Rietveld 408576698