Issue 484703002: Make internalized string parser in JSON.parse GC-safe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 484703002: Make internalized string parser in JSON.parse GC-safe (Closed)

Created:
6 years, 4 months ago by Yang

Modified:
6 years, 4 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Make internalized string parser in JSON.parse GC-safe SubStringKey::AsHandle is not GC-safe because the string backing store may move. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23185

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -70 lines)			Patch
M	src/factory.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	3 chunks	+12 lines, -7 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+5 lines, -42 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+5 lines, -19 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

Unfortunately I wasn't able to construct a test case. It reproduces at r23141 with ARM64 ...

6 years, 4 months ago (2014-08-18 15:42:27 UTC) #1

Yang

6 years, 4 months ago (2014-08-19 08:53:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as 23185 (presubmit successful).