runtime/vm/flow_graph_compiler_arm64.cc - Issue 484693003: Improve polymorphic inlining of int/int double/double operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 484693003: Improve polymorphic inlining of int/int double/double operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_arm64.cc

===================================================================

--- runtime/vm/flow_graph_compiler_arm64.cc (revision 39328)

+++ runtime/vm/flow_graph_compiler_arm64.cc (working copy)

@@ -1301,15 +1301,9 @@

intptr_t token_pos,

LocationSummary* locs,

const ICData& ic_data) {

- uword label_address = 0;

StubCode* stub_code = isolate()->stub_code();

- if (ic_data.NumArgsTested() == 0) {

- label_address = stub_code->ZeroArgsUnoptimizedStaticCallEntryPoint();

- } else if (ic_data.NumArgsTested() == 2) {

- label_address = stub_code->TwoArgsUnoptimizedStaticCallEntryPoint();

- } else {

- UNIMPLEMENTED();

- }

+ uword label_address =

srdjan 2014/08/18 18:04:49 const uword, here and on other architectures as we

Florian Schneider 2014/08/18 18:22:57 Done.

+ stub_code->UnoptimizedStaticCallEntryPoint(ic_data.NumArgsTested());

ExternalLabel target_label(label_address);

__ LoadObject(R5, ic_data, PP);

GenerateDartCall(deopt_id,

« runtime/vm/flow_graph_compiler_arm.cc ('K') | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | runtime/vm/flow_graph_optimizer.cc » ('J')