Record concat as setMatrix.

Record concat as setMatrix.

Mainly this cuts out a type to have to think about in SkRecord world.
It also means all the CTMs are recorded directly in the SkRecord, so
we can track the current CTM by pointer rather than by copying.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6332f1dd20d73a6d8b9564af7c27d09394eb6596

[mtklein, 2014-08-18 21:34:26]

As we talked about at lunch.

[mtklein, 2014-08-18 21:37:34]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-18 21:38:20]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/484673003/1

[commit-bot: I haz the power, 2014-08-18 21:38:21]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-08-19 03:38 UTC

[commit-bot: I haz the power, 2014-08-19 03:38:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-19 03:38:30]

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[reed1, 2014-08-19 13:59:31]

https://codereview.chromium.org/484673003/diff/1/src/core/SkRecorder.cpp
File src/core/SkRecorder.cpp (right):

https://codereview.chromium.org/484673003/diff/1/src/core/SkRecorder.cpp#newc...
src/core/SkRecorder.cpp:247: INHERITED(didConcat, matrix);
I vote to either move this INHERITED line above the getTotalMatrix call, or
remove it. As written it makes me (a naive reviewer) worry that the value of
getTotalMatrix might be modified after we sniff it.

[reed1, 2014-08-19 13:59:49]

lgtm w/ previous nit

[mtklein, 2014-08-19 14:01:59]

https://codereview.chromium.org/484673003/diff/1/src/core/SkRecorder.cpp
File src/core/SkRecorder.cpp (right):

https://codereview.chromium.org/484673003/diff/1/src/core/SkRecorder.cpp#newc...
src/core/SkRecorder.cpp:247: INHERITED(didConcat, matrix);
On 2014/08/19 13:59:31, reed1 wrote:
> I vote to either move this INHERITED line above the getTotalMatrix call, or
> remove it. As written it makes me (a naive reviewer) worry that the value of
> getTotalMatrix might be modified after we sniff it.

Done, to all the INHERITED calls which are always no-ops.

[mtklein, 2014-08-19 14:02:02]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2014-08-19 14:03:02]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/484673003/20001

[commit-bot: I haz the power, 2014-08-19 14:09:46]

Committed patchset #2 (20001) as 6332f1dd20d73a6d8b9564af7c27d09394eb6596