Fixed the inconsistent behavior when long pressing on editable area in Chrome.

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 1949 matching lines @@
   UpdateCompositionInfo(true);
 #endif
 }
 
 void RenderWidget::didHandleGestureEvent(
     const WebGestureEvent& event,
     bool event_cancelled) {
 #if defined(OS_ANDROID) || defined(USE_AURA)
   if (event_cancelled)
     return;
-  if (event.type == WebInputEvent::GestureTap ||
-      event.type == WebInputEvent::GestureLongPress) {
+  if (event.type == WebInputEvent::GestureTap) {
     UpdateTextInputState(SHOW_IME_IF_NEEDED, FROM_NON_IME);
+  } else if (event.type == WebInputEvent::GestureLongPress) {
+    blink::WebTextInputInfo new_info;
+    if (webwidget_)
+      new_info = webwidget_->textInputInfo();

[jdduke (slow), 2014/08/19 18:19:49]

Is there no other way of determining whether the input field is empty? This
query does some non-trivial work (string copying, etc...), which I suppose isn't
a huge deal as GestureLongPress is relatively infrequent, I just wonder if
there's a cheaper way of obtaining the same information.

[AKVT, 2014/08/20 15:00:43]

As I checked the code, there is no other way we can do this from existing flow,
we may have to add extra method to extract only required info. Please suggest
your opinion on this whether I can keep same or I have to write new function
from WebViewImpl.

[jdduke (slow), 2014/08/20 15:37:05]

I guess this is fine, but |didHandleGestureEvent| is a WebWidgetClient so we
should definitely still have a |webwidget_|, so you should instead do something
like:

DCHECK(webwidget_);
if (webwidget_->textInputInfo().value.isEmpty())
  UpdateTextInputState(NO_SHOW_IME, FROM_NON_IME);
else
  UpdateTextInputState(SHOW_IME_IF_NEEDED, FROM_NON_IME);

[jdduke (slow), 2014/08/20 15:37:49]

is a WebWidgetClient *method* that is.

[AKVT, 2014/08/20 18:20:17]

Done.

[AKVT, 2014/08/20 18:20:17]

Done. Thanks

+    if (!new_info.value.isEmpty())
+      UpdateTextInputState(SHOW_IME_IF_NEEDED, FROM_NON_IME);
+    else
+      UpdateTextInputState(NO_SHOW_IME, FROM_NON_IME);
   }
 #endif
 }
 
 void RenderWidget::StartCompositor() {
   // For widgets that are never visible, we don't need the compositor to run
   // at all.
   if (never_visible_)
     return;
   compositor_->setSurfaceReady();
@@ skipping 173 matching lines @@
 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.AddObserver(frame);
 }
 
 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.RemoveObserver(frame);
 }
 #endif  // defined(VIDEO_HOLE)
 
 }  // namespace content