Fixed the inconsistent behavior when long pressing on editable area in Chrome.

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 1949 matching lines @@
   UpdateCompositionInfo(true);
 #endif
 }
 
 void RenderWidget::didHandleGestureEvent(
     const WebGestureEvent& event,
     bool event_cancelled) {
 #if defined(OS_ANDROID) || defined(USE_AURA)
   if (event_cancelled)
     return;
-  if (event.type == WebInputEvent::GestureTap ||
-      event.type == WebInputEvent::GestureLongPress) {
+  if (event.type == WebInputEvent::GestureTap) {
     UpdateTextInputState(SHOW_IME_IF_NEEDED, FROM_NON_IME);
+  } else if (event.type == WebInputEvent::GestureLongPress) {
+    blink::WebTextInputInfo new_info;
+    if (webwidget_)
+      new_info = webwidget_->textInputInfo();
+    if (!new_info.value.isEmpty())
+      UpdateTextInputState(SHOW_IME_IF_NEEDED, FROM_NON_IME);

[aurimas (slooooooooow), 2014/08/18 16:05:24]

Conditionally calling UpdateTextInputState will cause all sorts of issues as
browser side IME state will not be initialized (AdapterInputConnection.java).
There are many callsites of UpdateTextInputState and the next one to call it
will push the update to Java defeating your conditional call.

[AKVT, 2014/08/18 16:14:30]

Thanks. In that case, how do we overcome this problem ? We need to handle from
Webkit side itself ? or let the call goes to AdapterInputConnection and prevent
IME showing from there ?
Please suggest your opinion

   }
 #endif
 }
 
 void RenderWidget::StartCompositor() {
   // For widgets that are never visible, we don't need the compositor to run
   // at all.
   if (never_visible_)
     return;
   compositor_->setSurfaceReady();
@@ skipping 173 matching lines @@
 void RenderWidget::RegisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.AddObserver(frame);
 }
 
 void RenderWidget::UnregisterVideoHoleFrame(RenderFrameImpl* frame) {
   video_hole_frames_.RemoveObserver(frame);
 }
 #endif  // defined(VIDEO_HOLE)
 
 }  // namespace content