Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(22)

Issue 484643002: Version 3.28.71.3 (merged r23081) (Closed)

Created:
4 years, 6 months ago by Jakob Kummerow
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Version 3.28.71.3 (merged r23081) Fix newly discovered presubmit errors. R=yangguo@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=23151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -126 lines) Patch
M src/api.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/instrument-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/base/platform/platform.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +8 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter-irregexp.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/libplatform/worker-thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/log.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/macro-assembler.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/optimizing-compiler-thread.h View 1 chunk +14 lines, -14 lines 0 comments Download
M src/splay-tree.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M test/base-unittests/platform/condition-variable-unittest.cc View 3 chunks +17 lines, -12 lines 0 comments Download
M test/base-unittests/platform/platform-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 8 chunks +13 lines, -11 lines 0 comments Download
M test/cctest/test-circular-queue.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M test/cctest/test-debug.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-libplatform.h View 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-lockers.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/test-semaphore.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-threads.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
4 years, 6 months ago (2014-08-18 12:06:20 UTC) #1
Yang
lgtm
4 years, 6 months ago (2014-08-18 12:09:50 UTC) #2
Jakob Kummerow
4 years, 6 months ago (2014-08-18 12:10:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23151 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698