Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 48463002: Temporarily disable calls to OS::TotalPhysicalMemory to avoid ASSERT when running under the Chrome … (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Temporarily disable calls to OS::TotalPhysicalMemory to avoid ASSERT when running under the Chrome Sandbox. This CL reverts the behaviour added in r16983 to avoid calling OS::TotalPhysicalMemory which fails an assert in the Chrome Sandbox. It reverts the default ResourceConstraints behaviour to that of V8 before r16983 (i.e., baseing these values purely on hard-coded checks against 64bit/32bit and Android/non-Android. This will be reverted once http://crbug.com/312241 has been resolved. BUG=312241 R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -25 lines) Patch
M src/defaults.cc View 1 chunk +9 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmcilroy
This, plus https://codereview.chromium.org/26868004/ should get rid of the ASSERTS in debug chromium until http://crbug.com/312241 is ...
7 years, 1 month ago (2013-10-28 10:16:25 UTC) #1
titzer
lgtm
7 years, 1 month ago (2013-10-28 12:31:31 UTC) #2
titzer
lgtm lgtm
7 years, 1 month ago (2013-10-28 12:31:31 UTC) #3
titzer
7 years, 1 month ago (2013-10-28 14:54:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r17415.

Powered by Google App Engine
This is Rietveld 408576698