Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Issue 484613002: Move apps::SizeConstraints to extensions (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move apps::SizeConstraints to extensions Move apps/size_constraints.{cc,h} to extensions/browser Change the namespace from apps to extensions BUG=403726 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290505

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : extensions/browser/app_window #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -171 lines) Patch
M apps/app_window.cc View 1 2 7 chunks +11 lines, -10 lines 0 comments Download
M apps/apps.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D apps/size_constraints.h View 1 chunk +0 lines, -57 lines 0 comments Download
D apps/size_constraints.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M apps/ui/views/native_app_window_views.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/app_window/size_constraints.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/app_window/size_constraints.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
Please review. Does it make sense to move AppWindow related code to extensions/browser? Perhaps, they ...
6 years, 4 months ago (2014-08-18 06:34:56 UTC) #1
benwells
Do you think it will make sense to create extensions/browser/app_window to keep things like app_window, ...
6 years, 4 months ago (2014-08-19 00:53:08 UTC) #2
hashimoto
On 2014/08/19 00:53:08, benwells wrote: > Do you think it will make sense to create ...
6 years, 4 months ago (2014-08-19 01:17:12 UTC) #3
benwells
lgtm On 2014/08/19 01:17:12, hashimoto wrote: > On 2014/08/19 00:53:08, benwells wrote: > > Do ...
6 years, 4 months ago (2014-08-19 02:44:52 UTC) #4
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-19 03:19:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/484613002/40001
6 years, 4 months ago (2014-08-19 03:20:18 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-19 04:34:19 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-19 05:51:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (40001) as 290505

Powered by Google App Engine
This is Rietveld 408576698