Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2154)

Unified Diff: chrome/browser/spellchecker/spellcheck_platform_mac.mm

Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/spellchecker/spellcheck_platform_mac.mm
diff --git a/chrome/browser/spellchecker/spellcheck_platform_mac.mm b/chrome/browser/spellchecker/spellcheck_platform_mac.mm
index a5951ed5169ec6b6315b76346147259bd0b7bb4e..434c66fd1689b4a94b6f5a6c5edb577d82162f6d 100644
--- a/chrome/browser/spellchecker/spellcheck_platform_mac.mm
+++ b/chrome/browser/spellchecker/spellcheck_platform_mac.mm
@@ -13,7 +13,6 @@
#include "base/logging.h"
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_nsexception_enabler.h"
-#include "base/metrics/histogram.h"
#include "base/strings/sys_string_conversions.h"
#include "base/time/time.h"
#include "chrome/common/spellcheck_common.h"
@@ -197,12 +196,8 @@ bool CheckSpelling(const base::string16& word_to_check, int tag) {
void FillSuggestionList(const base::string16& wrong_word,
std::vector<base::string16>* optional_suggestions) {
NSString* NS_wrong_word = base::SysUTF16ToNSString(wrong_word);
- TimeTicks debug_begin_time = base::Histogram::DebugNow();
// The suggested words for |wrong_word|.
NSArray* guesses = [SharedSpellChecker() guessesForWord:NS_wrong_word];
- DHISTOGRAM_TIMES("Spellcheck.SuggestTime",
- base::Histogram::DebugNow() - debug_begin_time);
-
for (int i = 0; i < static_cast<int>([guesses count]); ++i) {
if (i < chrome::spellcheck_common::kMaxSuggestions) {
optional_suggestions->push_back(base::SysNSStringToUTF16(
« no previous file with comments | « chrome/browser/safe_browsing/database_manager.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_engine.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698