chrome/browser/metrics/chrome_stability_metrics_provider.cc - Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider.cc

Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc

diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

index 7f669eb91bd3167fcbc9f0aad4f625d3f3192d0c..fbe79a6685a628878df59c2d133e9ec266b9ebec 100644

--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc

+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

@@ -187,7 +187,8 @@ void ChromeStabilityMetricsProvider::BrowserChildProcessCrashed(

void ChromeStabilityMetricsProvider::LogLoadStarted(

content::WebContents* web_contents) {

content::RecordAction(base::UserMetricsAction("PageLoad"));

- HISTOGRAM_ENUMERATION("Chrome.UmaPageloadCounter", 1, 2);

+ // TODO(asvitkine): Check if this is used for anything and if not, remove.

+ LOCAL_HISTOGRAM_BOOLEAN("Chrome.UmaPageloadCounter", true);

IncrementPrefValue(prefs::kStabilityPageLoadCount);

IncrementLongPrefsValue(prefs::kUninstallMetricsPageLoadCount);

// We need to save the prefs, as page load count is a critical stat, and it