Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: base/metrics/sparse_histogram.h

Issue 484603006: Add LOCAL_ prefix to non-UMA histogram macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove spellcheck histograms. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/sparse_histogram.h
diff --git a/base/metrics/sparse_histogram.h b/base/metrics/sparse_histogram.h
index 07d56603a5d8b4b7a85caadedbbf67d6dba39215..35e1ec28ba8f3ceb044068b96544e793006b9890 100644
--- a/base/metrics/sparse_histogram.h
+++ b/base/metrics/sparse_histogram.h
@@ -28,30 +28,13 @@ namespace base {
histogram->Add(sample); \
} while (0)
-#define HISTOGRAM_SPARSE_SLOWLY(name, sample) \
+#define LOCAL_HISTOGRAM_SPARSE_SLOWLY(name, sample) \
HISTOGRAM_SPARSE_COMMON(name, sample, base::HistogramBase::kNoFlags)
Ilya Sherman 2014/08/26 00:23:28 Actually, are there any uses of local sparse histo
Alexei Svitkine (slow) 2014/08/26 00:54:01 SGTM. Done. Also, did a little bit of cleanup to
#define UMA_HISTOGRAM_SPARSE_SLOWLY(name, sample) \
HISTOGRAM_SPARSE_COMMON(name, sample, \
base::HistogramBase::kUmaTargetedHistogramFlag)
-//------------------------------------------------------------------------------
-// Define debug only version of macros.
-#ifndef NDEBUG
-
-#define DHISTOGRAM_SPARSE_SLOWLY(name, sample) \
- HISTOGRAM_SPARSE_SLOWLY(name, sample)
-
-#else // NDEBUG
-
-#define DHISTOGRAM_SPARSE_SLOWLY(name, sample) \
- while (0) { \
- static_cast<void>(name); \
- static_cast<void>(sample); \
- }
-
-#endif // NDEBUG
-
class HistogramSamples;
class BASE_EXPORT_PRIVATE SparseHistogram : public HistogramBase {

Powered by Google App Engine
This is Rietveld 408576698