Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 484583002: Refactor SyncBuildAndRunRevision to remove deep nesting. (Closed)

Created:
6 years, 4 months ago by qyearsley
Modified:
6 years, 3 months ago
Reviewers:
prasadv, tonyg
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Refactor SyncBuildAndRunRevision to remove deep nesting. I also propose to rename this function to just RunTest, because its purpose is to do everything necessary to obtain a build and run a test to get results, and it's a relatively important and high-level function. "Flat is better than nested." -- The Zen of Python, PEP 20. BUG= Committed: https://crrev.com/01aea5538cc28f44485c6b3211c39cb49f758f26 Cr-Commit-Position: refs/heads/master@{#292661}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : Add config file #

Patch Set 7 : Rebased. #

Patch Set 8 : Rebased #

Patch Set 9 : Redo changes to bisect script. #

Patch Set 10 : Rebased (now using new name for config file) #

Patch Set 11 : #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -86 lines) Patch
M tools/auto_bisect/bisect.cfg View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +11 lines, -7 lines 0 comments Download
M tools/bisect-perf-regression.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 10 chunks +96 lines, -79 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
qyearsley
6 years, 4 months ago (2014-08-18 16:19:52 UTC) #1
qyearsley
6 years, 4 months ago (2014-08-18 16:19:54 UTC) #2
tonyg
Please get a green bisect run w/ this patch and then lgtm
6 years, 4 months ago (2014-08-18 16:36:16 UTC) #3
qyearsley
On 2014/08/18 16:36:16, tonyg wrote: > Please get a green bisect run w/ this patch ...
6 years, 3 months ago (2014-08-29 16:19:18 UTC) #4
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 3 months ago (2014-08-29 16:19:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/484583002/260001
6 years, 3 months ago (2014-08-29 16:19:55 UTC) #6
commit-bot: I haz the power
Committed patchset #14 (id:260001) as 71e8ac4a2037c217484db8ce393267ff43a33e46
6 years, 3 months ago (2014-08-29 17:16:56 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:46 UTC) #8
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/01aea5538cc28f44485c6b3211c39cb49f758f26
Cr-Commit-Position: refs/heads/master@{#292661}

Powered by Google App Engine
This is Rietveld 408576698