Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 484473002: Revert of Replace enable-compositing-for-fixed-position with prefer-compositing-to-lcd-text. (Closed)

Created:
6 years, 4 months ago by tdanderson
Modified:
6 years, 4 months ago
Reviewers:
Robert Sesek, danakj, sky, piman
CC:
chromium-reviews, creis+watch_chromium.org, nkostylev+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, abarth-chromium, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

Revert of Replace enable-compositing-for-fixed-position with prefer-compositing-to-lcd-text. (patchset #1 of https://codereview.chromium.org/479653003/) Reason for revert: Reverting due to compile step failure on Linux ChromiumOS Builder (dbg) (see http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/50238). Original issue's description: > Replace enable-compositing-for-fixed-position with prefer-compositing-to-lcd-text. > > We are adding a --prefer-compositing-to-lcd-text flag to allow promoting > of things that will lose LCD text. Fixed position elements will be the > only thing controlled by this flag in this CL. Other flags will be > merged into it in the future. > > R=piman@chromium.org > BUG=365851 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290155 TBR=piman@chromium.org,rsesek@chromium.org,sky@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=365851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -19 lines) Patch
M chrome/browser/about_flags.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/crash_keys.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 3 chunks +19 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tdanderson
Created Revert of Replace enable-compositing-for-fixed-position with prefer-compositing-to-lcd-text.
6 years, 4 months ago (2014-08-16 20:42:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/484473002/1
6 years, 4 months ago (2014-08-16 20:43:10 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-16 20:43:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (1) as 290156

Powered by Google App Engine
This is Rietveld 408576698