Issue 484393002: pdf: Use the default resource if high-dpi resources are unavailable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 484393002: pdf: Use the default resource if high-dpi resources are unavailable. (Closed)

Created:
6 years, 4 months ago by sadrul

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

pdf: Use the default resource if high-dpi resources are unavailable. BUG=401242 R=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290766

Patch Set 2 : . #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	pdf/instance.cc	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm default is misspelled in the commit msg. https://codereview.chromium.org/484393002/diff/1/pdf/instance.cc File pdf/instance.cc (right): https://codereview.chromium.org/484393002/diff/1/pdf/instance.cc#newcode2509 pdf/instance.cc:2509: resource_data ...

6 years, 4 months ago (2014-08-20 04:21:17 UTC) #2

sadrul

> default is misspelled in the commit msg. Fixed, thanks! https://codereview.chromium.org/484393002/diff/1/pdf/instance.cc File pdf/instance.cc (right): https://codereview.chromium.org/484393002/diff/1/pdf/instance.cc#newcode2509 ...

6 years, 4 months ago (2014-08-20 04:44:40 UTC) #3

sadrul

6 years, 4 months ago (2014-08-20 05:04:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 290766 (presubmit successful).

Expand Messages | Collapse Messages

Issue 484393002: pdf: Use the default resource if high-dpi resources are unavailable. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages