Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: Source/core/page/FocusController.cpp

Issue 484383002: Disable the focus moves to an element which doesn't satisfy the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/events/tabindex-no-focusable-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/FocusController.cpp
diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp
index 149ff8a87bca01cdc267d43e738c6569f5615562..6ed173f09492a64f7a8c453c3e22a6f21caf978b 100644
--- a/Source/core/page/FocusController.cpp
+++ b/Source/core/page/FocusController.cpp
@@ -579,6 +579,7 @@ Node* FocusController::nextFocusableNode(FocusNavigationScope scope, Node* start
if (shouldVisit(node) && adjustedTabIndex(node) >= 0)
return node;
}
+ return 0;
hayato 2014/08/25 06:52:16 I am afraid we couldn't return 0 here. Suppose we
}
// First try to find a node with the same tabindex as start that comes after start in the scope.
@@ -626,6 +627,7 @@ Node* FocusController::previousFocusableNode(FocusNavigationScope scope, Node* s
if (shouldVisit(node) && adjustedTabIndex(node) >= 0)
return node;
}
+ return 0;
hayato 2014/08/25 06:52:16 Ditto
}
if (Node* winner = findNodeWithExactTabIndex(startingNode, startingTabIndex, FocusTypeBackward))
« no previous file with comments | « LayoutTests/fast/events/tabindex-no-focusable-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698