LayoutTests/fast/events/tabindex-no-focusable.html - Issue 484383002: Disable the focus moves to an element which doesn't satisfy the spec.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/tabindex-no-focusable.html

Issue 484383002: Disable the focus moves to an element which doesn't satisfy the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use document.activeElement Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner)	2 if (window.testRunner)

3 testRunner.dumpAsText();	3 testRunner.dumpAsText();

4	4

5 var key = 0;

6 function test()	5 function test()

7 {	6 {

8 if (!window.testRunner)	7 if (!window.testRunner)

9 return;	8 return;

10	9 var elem_movetome = document.getElementById('MoveToMe');

11 var elem = document.getElementById('focusMe')	10 var elem_focusme = document.getElementById('focusMe');

12 key = -1;	11 elem_focusme.focus();

13 elem.focus();

14 eventSender.keyDown("\t");	12 eventSender.keyDown("\t");

	13 var current_focus = document.activeElement;

15	14

16 if (!key) { // first test passed, continue with second test	15 if (current_focus = elem_movetome) { // first test passed, continue with sec ond test
	hayato 2014/09/10 05:56:40 This should be '==' instead of '=', shouldn't this This should be '==' instead of '=', shouldn't this? yanagawa 2014/09/12 03:10:55 Done. Show quoted text On 2014/09/10 05:56:40, hayato wrote: > This should be '==' instead of '=', shouldn't this? Done.
17 key = 1;	16 elem_focusme.focus();

18 elem.focus();

19 eventSender.keyDown("\t",["shiftKey"]);	17 eventSender.keyDown("\t",["shiftKey"]);

20	18

21 if (!key) { // second test passed	19 if (current_focus = elem_movetome) { // second test passed
	hayato 2014/09/10 05:56:40 Because the focused element has changed by sending Because the focused element has changed by sending [shift+tab], current_focus is no longer equal to document.activeElement. You should use document.activeElement again. You might want to use console.log(current_focus) to see what is assigned to current_focus. yanagawa 2014/09/12 03:10:55 Done. Show quoted text On 2014/09/10 05:56:40, hayato wrote: > Because the focused element has changed by sending [shift+tab], current_focus is > no longer equal to document.activeElement. You should use document.activeElement > again. > > You might want to use console.log(current_focus) to see what is assigned to > current_focus. Done.
22 document.write("PASSED");	20 document.write("PASSED");

23 document.close();	21 document.close();

24 return;	22 return;

25 }	23 }

26 }	24 }

27 document.write("FAILED");	25 document.write("FAILED");

28 document.close();	26 document.close();

29 }	27 }

30 </script>	28 </script>

31 <body onload="test()">	29 <body onload="test()">

32 <input onfocus="key-=1">	30 <input id="MoveToMe" tabindex="1">

	31 <input tabindex="-1">

33 <input id="focusMe" tabindex="-1">	32 <input id="focusMe" tabindex="-1">

34 <input onfocus="key+=1">	33 <input tabindex="-1">

35 <div id="results"></div>	34 <div id="results"></div>

36 </body>	35 </body>

	36

	37

OLD	NEW