cc: Don't consider tiles at the layers raster_contents_scale incomplete

cc: Don't consider tiles at the layers raster_contents_scale incomplete

When PictureLayerImpl chooses a scale to raster at, we should accept
tiles at that scale as complete, and not try wait for tiles at some
other scale to be filled in. Such a tiling may not even exist.

R=enne, vmpstr
BUG=406433
Committed: https://chromium.googlesource.com/chromium/src/+/60c7d86bb7685d8ca04ee53ae20fcdd6cd37eb5f

Committed: https://crrev.com/e6f63e7b2b1868ad015f443115c1ee722a28e6f1
Cr-Commit-Position: refs/heads/master@{#291712}

[enne (OOO), 2014-08-22 20:01:43]

lgtm.  Could you maybe leave a comment there on the conditional where multiple
scales are considered acceptable?

[danakj, 2014-08-23 00:05:23]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-08-23 00:05:23]

On 2014/08/22 20:01:43, enne wrote:
> lgtm.  Could you maybe leave a comment there on the conditional where multiple
> scales are considered acceptable?

Done.

[commit-bot: I haz the power, 2014-08-23 04:56:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/484363003/40001

[commit-bot: I haz the power, 2014-08-23 10:53:26]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-23 22:10:14]

Committed patchset #3 (40001) as 60c7d86bb7685d8ca04ee53ae20fcdd6cd37eb5f

[Finnur, 2014-08-25 09:58:14]

A revert of this CL (patchset #3) has been created in
https://codereview.chromium.org/505723002/ by finnur@chromium.org.

The reason for reverting is: Unit test added fails all the time.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

[danakj, 2014-08-25 14:52:50]

On 2014/08/25 09:58:14, Finnur wrote:
> A revert of this CL (patchset #3) has been created in
> https://codereview.chromium.org/505723002/ by mailto:finnur@chromium.org.
> 
> The reason for reverting is: Unit test added fails all the time.
> 
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....

Hm... dat asan :) Guessing the quads are in a different order with asan or
something. Or maybe something is uninit.

[danakj, 2014-08-25 17:04:59]

The CQ bit was checked by danakj@chromium.org

[danakj, 2014-08-25 17:05:24]

Fixed the test by using TileAt(0,0) instead of AllTilesForTesting() and then
dropping everything but the first tile in the list. The latter is not
deterministic.

[commit-bot: I haz the power, 2014-08-25 17:05:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/danakj@chromium.org/484363003/60001

[commit-bot: I haz the power, 2014-08-25 18:02:08]

Committed patchset #4 (60001) as d69c08f3ee6c92ee5d7f68fc76ec3ac4f33295c1

[earthdok, 2014-09-09 17:49:06]

On 2014/08/25 14:52:50, danakj wrote:
> On 2014/08/25 09:58:14, Finnur wrote:
> > A revert of this CL (patchset #3) has been created in
> > https://codereview.chromium.org/505723002/ by mailto:finnur@chromium.org.
> > 
> > The reason for reverting is: Unit test added fails all the time.
> > 
> >
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....
> 
> Hm... dat asan :) Guessing the quads are in a different order with asan or
> something. Or maybe something is uninit.

ASan builds use libc++, not libstdc++ which is the default on Linux. If for
instance you rely on specific iteration order in standard containers (where it's
not specified by the standard), things may break.

[danakj, 2014-09-09 17:50:06]

On 2014/09/09 17:49:06, earthdok wrote:
> On 2014/08/25 14:52:50, danakj wrote:
> > On 2014/08/25 09:58:14, Finnur wrote:
> > > A revert of this CL (patchset #3) has been created in
> > > https://codereview.chromium.org/505723002/ by mailto:finnur@chromium.org.
> > > 
> > > The reason for reverting is: Unit test added fails all the time.
> > > 
> > >
> >
>
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Te....
> > 
> > Hm... dat asan :) Guessing the quads are in a different order with asan or
> > something. Or maybe something is uninit.
> 
> ASan builds use libc++, not libstdc++ which is the default on Linux. If for
> instance you rely on specific iteration order in standard containers (where
it's
> not specified by the standard), things may break.

It's great that it breaks, btw, I wasn't complaining. :)

[commit-bot: I haz the power, 2014-09-10 02:31:54]

Patchset 4 (id:??) landed as
https://crrev.com/ef468cde5048721e27faa4265f70f2fd0e424618
Cr-Commit-Position: refs/heads/master@{#291604}

[commit-bot: I haz the power, 2014-09-10 02:35:37]

Patchset 4 (id:??) landed as
https://crrev.com/e6f63e7b2b1868ad015f443115c1ee722a28e6f1
Cr-Commit-Position: refs/heads/master@{#291712}