LayoutTests/editing/spelling/spelling-should-select-single-word.html - Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/editing/spelling/spelling-should-select-single-word.html

Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: More quoting consistency wibbles Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/spelling/spelling-should-select-multiple-words.html ('k') | LayoutTests/editing/spelling/spelling-subword-selection.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/spelling/spelling-should-select-single-word.html

diff --git a/LayoutTests/editing/spelling/spelling-should-select-single-word.html b/LayoutTests/editing/spelling/spelling-should-select-single-word.html

index 08bbaf03bac521d6b2ca07c9b22c452ae22d4911..557ef85cf14bb048ac93dccac093dab250b13699 100644

--- a/LayoutTests/editing/spelling/spelling-should-select-single-word.html

+++ b/LayoutTests/editing/spelling/spelling-should-select-single-word.html

@@ -30,7 +30,7 @@ initSpellTest("destination", "wellcome home.", function(textNode) {

eventSender.mouseMoveTo(x, y);

contextMenuElements = eventSender.contextClick();

// Esc key to hide the context menu.

- eventSender.keyDown(String.fromCharCode(0x001B), null);

+ eventSender.keyDown("escape", null);

spellingMarkerRange = internals.markerRangeForNode(textNode, "spelling", 0);

shouldBeEqualToString("spellingMarkerRange.toString()", "wellcome");

@@ -46,7 +46,7 @@ initSpellTest("destination", "wellcome home.", function(textNode) {

eventSender.mouseMoveTo(x, y);

contextMenuElements = eventSender.contextClick();

// Esc key to hide the context menu.

- eventSender.keyDown(String.fromCharCode(0x001B), null);

+ eventSender.keyDown("escape", null);

// Context click should select correctly spelled words only with "win" editing behavior.

if (behaviors[i] == "mac")