LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html - Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html

Issue 484353004: Test tidying: use "escape" and "backspace" with eventSender.keyDown() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html ('K') | « LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html ('k') | LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html » ('j') | LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html

diff --git a/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html b/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html

index 7d471a29c2c0a628bb0c044979d265fbaf7b220b..18088a6fd89766bfc3b4a2059d8f04a40ce45839 100644

--- a/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html

+++ b/LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html

@@ -51,7 +51,7 @@ function test1() {

shouldBeEqualToString('entryValues()[5]', '2012-01-31');

shouldBeEqualToString('entryValues()[6]', '@openCalendarPicker');

- eventSender.keyDown('\x1B'); // Close picker.

+ eventSender.keyDown("escape"); // Close picker.

keishi 2014/08/22 07:22:32 nit: string literals in this file are using single

waitUntilClosing(test1AfterClosing);

}

@@ -69,7 +69,7 @@ function test2() {

shouldBeEqualToString('entryValues()[2]', '2012-01-31');

shouldBeEqualToString('entryValues()[3]', '@openCalendarPicker');

- eventSender.keyDown('\x1B'); // Close picker.

+ eventSender.keyDown("escape"); // Close picker.

keishi 2014/08/22 07:22:32 Ditto.

waitUntilClosing(test2AfterClosing);

}