Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 484353003: Remove the assertion that number of expected tabs must equal to number of live tabs temporarily. (Closed)

Created:
6 years, 4 months ago by nednguyen
Modified:
6 years, 4 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the assertion that number of expected tabs must equal to number of live tabs temporarily. BUG=405955 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/tab_list_backend.py View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
nednguyen
6 years, 4 months ago (2014-08-21 18:12:55 UTC) #1
tonyg
lgtm
6 years, 4 months ago (2014-08-21 18:32:28 UTC) #2
nednguyen
On 2014/08/21 18:32:28, tonyg wrote: > lgtm The previous CL was reverted, so this patch ...
6 years, 4 months ago (2014-08-21 18:39:13 UTC) #3
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 00:23:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/484353003/1
6 years, 4 months ago (2014-08-22 00:25:19 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 01:54:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 01:58:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/8328)
6 years, 4 months ago (2014-08-22 01:58:12 UTC) #8
dtu
The CQ bit was checked by dtu@chromium.org
6 years, 4 months ago (2014-08-22 02:03:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/484353003/1
6 years, 4 months ago (2014-08-22 02:05:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 02:51:41 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 03:47:08 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1229)
6 years, 4 months ago (2014-08-22 03:47:09 UTC) #13
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 04:10:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/484353003/1
6 years, 4 months ago (2014-08-22 04:11:37 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 05:07:03 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 06:07:41 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/1292)
6 years, 4 months ago (2014-08-22 06:07:42 UTC) #18
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 4 months ago (2014-08-22 07:50:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/484353003/1
6 years, 4 months ago (2014-08-22 07:51:45 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 08:46:28 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (1) as 291368
6 years, 4 months ago (2014-08-22 10:19:31 UTC) #22
nednguyen
6 years, 4 months ago (2014-08-22 16:23:04 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/495393002/ by nednguyen@google.com.

The reason for reverting is: The original patch of this
(https://codereview.chromium.org/449753002/) broke chromeos bot in
https://code.google.com/p/chromium/issues/detail?id=406010.

Powered by Google App Engine
This is Rietveld 408576698