Fix handling of skipped tests in telemetry_unittests when uploading results.

Fix handling of skipped tests in telemetry_unittests when uploading results.

This fixes a crash when we skip a test only on ChromeOS; it turns out
that telemetry uses two mechanisms for disabling tests, and only one of
them was provoking this; that mechanism only seems to be used for this
one ChromeOS test (everything else uses the other mechanism).

R=dtu@chromium.org, nduca@chromium.org
BUG=397279
Committed: https://crrev.com/9e560b59f3584c12e697ef9f0f3da38e1a37a1c7
Cr-Commit-Position: refs/heads/master@{#291980}

[achuithb, 2014-08-20 18:52:29]

It would be great if we could land this patch sometime this week as it's causing
the cros bots (they are fyi only, so this is not P0) to be red.

[Dirk Pranke, 2014-08-20 19:05:48]

On 2014/08/20 18:52:29, achuithb wrote:
> It would be great if we could land this patch sometime this week as it's
causing
> the cros bots (they are fyi only, so this is not P0) to be red.

Oh, sorry! I thought I had CQ'ed this already.

[Dirk Pranke, 2014-08-20 19:05:55]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-08-20 19:06:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/484333002/1

[commit-bot: I haz the power, 2014-08-20 19:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 19:06:57]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Dirk Pranke, 2014-08-20 19:09:20]

On 2014/08/20 19:06:57, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Bah ... Dave, Nat, Tony, can one of you please take a look?

[Dirk Pranke, 2014-08-20 19:10:32]

Note that we should probably also change the test in question to not use
unittest.skipUnless(), and instead use the normal decorators.Disabled()
mechanism for consistency instead, but that should be done *in addition* to this
patch.

[achuithb, 2014-08-20 19:12:57]

On 2014/08/20 19:10:32, Dirk Pranke wrote:
> Note that we should probably also change the test in question to not use
> unittest.skipUnless(), and instead use the normal decorators.Disabled()
> mechanism for consistency instead, but that should be done *in addition* to
this
> patch.

I don't want to lg2m this patch since I'm not particularly familiar with this
code and it's complex enough.

[tonyg, 2014-08-20 20:54:22]

lgtm

[Dirk Pranke, 2014-08-20 20:54:38]

The CQ bit was checked by dpranke@chromium.org

[commit-bot: I haz the power, 2014-08-20 20:55:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/484333002/1

[commit-bot: I haz the power, 2014-08-20 22:50:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-20 22:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-20 22:54:23]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[achuithb, 2014-08-26 19:48:00]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-08-26 19:49:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dpranke@chromium.org/484333002/1

[commit-bot: I haz the power, 2014-08-26 20:43:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[commit-bot: I haz the power, 2014-08-26 21:07:29]

Committed patchset #1 (1) as 2751209356bed5e132dac743751d462b63e7eb20

[commit-bot: I haz the power, 2014-09-10 02:45:34]

Patchset 1 (id:??) landed as
https://crrev.com/9e560b59f3584c12e697ef9f0f3da38e1a37a1c7
Cr-Commit-Position: refs/heads/master@{#291980}