|
|
Created:
6 years, 4 months ago by Zhenyao Mo Modified:
6 years, 4 months ago CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers Base URL:
svn://svn.chromium.org/blink/trunk Project:
blink Visibility:
Public. |
DescriptionAdd logging for ScriptedAnimationController.
This is for debugging RAF based WebGL conformance tests random timeouts.
BUG=393331
TEST=bots
NOTRY=true
R=kbr@chromium.org,eseidel@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180672
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180685
Patch Set 1 #Patch Set 2 : Fix for 64 bit compile #Patch Set 3 : #
Messages
Total messages: 26 (0 generated)
Please review
lgtm
Eric: ping On Tue, Aug 19, 2014 at 7:29 PM, <kbr@chromium.org> wrote: > lgtm > > > > https://codereview.chromium.org/484323002/ > To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Ken is an owner. :) lgtm too. Maybe when you all are done here you can delete some of the channels which are now dead and gone. :) Or maybe we should file a bug with "GoodFirstBug" for someone else to do so.
On 2014/08/20 16:25:16, eseidel wrote: > Ken is an owner. :) lgtm too. Maybe when you all are done here you can delete > some of the channels which are now dead and gone. :) Or maybe we should file a > bug with "GoodFirstBug" for someone else to do so. Sure. I'll clean up the dead channels. It should only take a few minutes.
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23682)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23698)
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/1
Message was sent while issue was closed.
Committed patchset #1 (1) as 180672
Message was sent while issue was closed.
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/488863004/ by dglazkov@chromium.org. The reason for reverting is: Broke https://build.chromium.org/p/chromium.webkit/builders/Android%20Builder%20(db....
Message was sent while issue was closed.
Very unfortunate that teh CQ didn't catch this. Which CQ config are we missing and would someone please file a bug and mark it Infra-CodeYellow and CY-CQMatchesWaterfall? We should be able to 100% trust that the CQ will not break the tree.
Message was sent while issue was closed.
On 2014/08/20 at 20:12:56, eseidel wrote: > Very unfortunate that teh CQ didn't catch this. Which CQ config are we missing and would someone please file a bug and mark it Infra-CodeYellow and CY-CQMatchesWaterfall? We should be able to 100% trust that the CQ will not break the tree. https://code.google.com/p/chromium/issues/detail?id=405674
kbr: please take another look. This should fix the 64 bit compile issue.
LGTM again.
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2...) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23745) linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/40001
Message was sent while issue was closed.
Committed patchset #3 (40001) as 180685 |