Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 484323002: Add logging for ScriptedAnimationController. (Closed)

Created:
6 years, 4 months ago by Zhenyao Mo
Modified:
6 years, 4 months ago
CC:
blink-reviews, rwlbuis, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, blink-reviews-dom_chromium.org, darktears, Steve Block, Eric Willigers
Project:
blink
Visibility:
Public.

Description

Add logging for ScriptedAnimationController. This is for debugging RAF based WebGL conformance tests random timeouts. BUG=393331 TEST=bots NOTRY=true R=kbr@chromium.org,eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180672 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180685

Patch Set 1 #

Patch Set 2 : Fix for 64 bit compile #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M Source/core/dom/ScriptedAnimationController.cpp View 1 2 8 chunks +18 lines, -0 lines 0 comments Download
M Source/platform/Logging.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/Logging.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
Zhenyao Mo
Please review
6 years, 4 months ago (2014-08-20 00:01:40 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 4 months ago (2014-08-20 02:29:19 UTC) #2
Zhenyao Mo
Eric: ping On Tue, Aug 19, 2014 at 7:29 PM, <kbr@chromium.org> wrote: > lgtm > ...
6 years, 4 months ago (2014-08-20 16:11:08 UTC) #3
eseidel
Ken is an owner. :) lgtm too. Maybe when you all are done here you ...
6 years, 4 months ago (2014-08-20 16:25:16 UTC) #4
Zhenyao Mo
On 2014/08/20 16:25:16, eseidel wrote: > Ken is an owner. :) lgtm too. Maybe when ...
6 years, 4 months ago (2014-08-20 16:30:44 UTC) #5
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-08-20 16:31:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/1
6 years, 4 months ago (2014-08-20 16:32:00 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-20 17:36:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 18:20:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23698)
6 years, 4 months ago (2014-08-20 18:20:28 UTC) #10
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-08-20 18:25:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/1
6 years, 4 months ago (2014-08-20 18:25:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (1) as 180672
6 years, 4 months ago (2014-08-20 18:27:04 UTC) #13
dglazkov
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/488863004/ by dglazkov@chromium.org. The ...
6 years, 4 months ago (2014-08-20 20:11:09 UTC) #14
eseidel
Very unfortunate that teh CQ didn't catch this. Which CQ config are we missing and ...
6 years, 4 months ago (2014-08-20 20:12:56 UTC) #15
dglazkov
On 2014/08/20 at 20:12:56, eseidel wrote: > Very unfortunate that teh CQ didn't catch this. ...
6 years, 4 months ago (2014-08-20 20:15:27 UTC) #16
Zhenyao Mo
kbr: please take another look. This should fix the 64 bit compile issue.
6 years, 4 months ago (2014-08-20 22:07:43 UTC) #17
Ken Russell (switch to Gerrit)
LGTM again.
6 years, 4 months ago (2014-08-20 22:11:56 UTC) #18
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-08-20 22:12:16 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/40001
6 years, 4 months ago (2014-08-20 22:13:19 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-20 23:35:20 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 23:37:39 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/21601)
6 years, 4 months ago (2014-08-20 23:37:41 UTC) #23
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 4 months ago (2014-08-20 23:40:10 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/484323002/40001
6 years, 4 months ago (2014-08-20 23:40:28 UTC) #25
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 23:41:53 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (40001) as 180685

Powered by Google App Engine
This is Rietveld 408576698