Load closure from activation for building literals.

Reland "Load global object and builtins from activation."

Reland fixes:
Don't set string flags (doing so leaks memory).

Load closure from activation for building literals.

R=titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23275

[sigurds, 2014-08-20 07:53:22]

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-jscalls.cc:252: FLAG_context_specialization =
false;
I left this flag in here.
I could add it as a parameter to Pipeline, and expose the parameter through
function tester.

[titzer, 2014-08-21 08:12:06]

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-jscalls.cc:252: FLAG_context_specialization =
false;
On 2014/08/20 07:53:22, sigurds wrote:
> I left this flag in here.
> I could add it as a parameter to Pipeline, and expose the parameter through
> function tester.

Please add a TODO.

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-jscalls.cc:263: v8::Local<v8::Context> env =
v8::Context::New(isolate);
Maybe you can factor this out into function-tester as RunInSeparateContext or
something?

[sigurds, 2014-08-21 09:14:14]

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-jscalls.cc:252: FLAG_context_specialization =
false;
On 2014/08/21 08:12:06, titzer wrote:
> On 2014/08/20 07:53:22, sigurds wrote:
> > I left this flag in here.
> > I could add it as a parameter to Pipeline, and expose the parameter through
> > function tester.
> 
> Please add a TODO.
Implemented it.

https://codereview.chromium.org/484273003/diff/1/test/cctest/compiler/test-ru...
test/cctest/compiler/test-run-jscalls.cc:263: v8::Local<v8::Context> env =
v8::Context::New(isolate);
On 2014/08/21 08:12:06, titzer wrote:
> Maybe you can factor this out into function-tester as RunInSeparateContext or
> something?

Done.

https://codereview.chromium.org/484273003/diff/20001/test/cctest/compiler/tes...
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/20001/test/cctest/compiler/tes...
test/cctest/compiler/test-run-jscalls.cc:262: [&T](v8::Handle<v8::Context>
context, Handle<JSFunction> function) {
Look at this beautiful lambda :)
I'll replace it with a static function if desired.

[sigurds, 2014-08-21 09:49:47]

And again without lambdas.

[titzer, 2014-08-21 09:56:35]

https://codereview.chromium.org/484273003/diff/40001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/484273003/diff/40001/src/compiler/pipeline.h#...
src/compiler/pipeline.h:29: : info_(info),
context_specialization_(context_specialization) {}
Let's make this a mutable field and not a constructor parameter. I foresee many
such options and making them all constructor parameters will become cumbersome.

https://codereview.chromium.org/484273003/diff/40001/test/cctest/compiler/tes...
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/40001/test/cctest/compiler/tes...
test/cctest/compiler/test-run-jscalls.cc:249: #if V8_TURBOFAN_TARGET
Why are these guarded with TURBOFAN_TARGET and the others are not?

[sigurds, 2014-08-21 12:29:00]

Trybots seem to have problem at the moment.

https://codereview.chromium.org/484273003/diff/40001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/484273003/diff/40001/src/compiler/pipeline.h#...
src/compiler/pipeline.h:29: : info_(info),
context_specialization_(context_specialization) {}
On 2014/08/21 09:56:35, titzer wrote:
> Let's make this a mutable field and not a constructor parameter. I foresee
many
> such options and making them all constructor parameters will become
cumbersome.

Done.

https://codereview.chromium.org/484273003/diff/40001/test/cctest/compiler/tes...
File test/cctest/compiler/test-run-jscalls.cc (right):

https://codereview.chromium.org/484273003/diff/40001/test/cctest/compiler/tes...
test/cctest/compiler/test-run-jscalls.cc:249: #if V8_TURBOFAN_TARGET
On 2014/08/21 09:56:35, titzer wrote:
> Why are these guarded with TURBOFAN_TARGET and the others are not?

Leftover, thanks. Removed guard.

[titzer, 2014-08-21 12:35:38]

lgtm

[sigurds, 2014-08-21 12:40:20]

Committed patchset #4 manually as 23275 (presubmit successful).