Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: ui/views/controls/menu/menu_controller.cc

Issue 484133002: "F4" doesn't close/open the "Folder" dropdown on "Bookmark added!" pop-up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« AUTHORS ('K') | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_controller.cc
diff --git a/ui/views/controls/menu/menu_controller.cc b/ui/views/controls/menu/menu_controller.cc
index 19936f31bcfc12d601386c30ab64b1a583e4fd00..f6866fbfee672c018fff79090b25e643f304abd0 100644
--- a/ui/views/controls/menu/menu_controller.cc
+++ b/ui/views/controls/menu/menu_controller.cc
@@ -1038,7 +1038,11 @@ bool MenuController::OnKeyDown(ui::KeyboardCode key_code) {
case ui::VKEY_RETURN:
if (pending_state_.item) {
if (pending_state_.item->HasSubmenu()) {
- OpenSubmenuChangeSelectionIfCan();
+ if (key_code == ui::VKEY_F4 &&
+ pending_state_.item->GetSubmenu()->IsShowing())
sky 2014/08/20 02:45:39 Why does it matter whether the submenu is showing?
Deepak 2014/08/20 03:37:33 As When Submneu is shown, and we select F4, we wan
sky 2014/08/20 15:21:39 Comboboxs don't have submenus, right?
+ return false;
+ else
+ OpenSubmenuChangeSelectionIfCan();
} else {
SendAcceleratorResultType result = SendAcceleratorToHotTrackedView();
if (result == ACCELERATOR_NOT_PROCESSED &&
« AUTHORS ('K') | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698