Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 48413004: Narrow VDA Decode() API and remove multi-frame tests. (Closed)

Created:
7 years, 1 month ago by yuli
Modified:
7 years, 1 month ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Narrow VDA Decode() API and remove multi-frame tests. BUG=chrome-os-partner:20275 TEST=build and run the test on daisy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231652

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -105 lines) Patch
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 24 chunks +63 lines, -99 lines 0 comments Download
M media/video/video_decode_accelerator.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/api/dev/ppb_video_decoder_dev.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/c/dev/ppb_video_decoder_dev.h View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
yuli
7 years, 1 month ago (2013-10-28 15:55:16 UTC) #1
Ami GONE FROM CHROMIUM
+ihf: can you OK this API change? @yuli: Please also update https://code.google.com/p/chromium/codesearch#chromium/src/ppapi/api/dev/ppb_video_decoder_dev.idl&l=65 https://codereview.chromium.org/48413004/diff/1/media/video/video_decode_accelerator.h File media/video/video_decode_accelerator.h ...
7 years, 1 month ago (2013-10-28 16:05:56 UTC) #2
Ami GONE FROM CHROMIUM
On 2013/10/28 16:05:56, Ami Fischman wrote: > +ihf: can you OK this API change? (by ...
7 years, 1 month ago (2013-10-28 16:06:19 UTC) #3
yuli
Thanks. Please take another look. https://codereview.chromium.org/48413004/diff/1/media/video/video_decode_accelerator.h File media/video/video_decode_accelerator.h (right): https://codereview.chromium.org/48413004/diff/1/media/video/video_decode_accelerator.h#newcode93 media/video/video_decode_accelerator.h:93: // Decodes given bitstream ...
7 years, 1 month ago (2013-10-28 16:38:40 UTC) #4
Ami GONE FROM CHROMIUM
LGTM please wait for confirmation from ihf.
7 years, 1 month ago (2013-10-28 17:17:01 UTC) #5
Pawel Osciak
lgtm (assuming we don't need to uprev flash api version).
7 years, 1 month ago (2013-10-29 04:18:49 UTC) #6
ilja
I think it is ok but let me ping Adobe first.
7 years, 1 month ago (2013-10-29 04:29:22 UTC) #7
ilja
They are fine with it.
7 years, 1 month ago (2013-10-29 04:48:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yuli@chromium.org/48413004/70001
7 years, 1 month ago (2013-10-29 06:40:58 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=33074
7 years, 1 month ago (2013-10-29 06:56:34 UTC) #10
yuli
Need OWNER's LGTM. Thanks.
7 years, 1 month ago (2013-10-29 07:10:08 UTC) #11
binji
ppapi lgtm
7 years, 1 month ago (2013-10-29 15:35:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yuli@chromium.org/48413004/70001
7 years, 1 month ago (2013-10-29 15:45:45 UTC) #13
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=33137
7 years, 1 month ago (2013-10-29 16:06:32 UTC) #14
yuli
Need OWNER's LGTM for ppb_video_decoder_dev.h. Thanks.
7 years, 1 month ago (2013-10-29 16:33:48 UTC) #15
bbudge
ppapi LGTM
7 years, 1 month ago (2013-10-29 16:51:25 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yuli@chromium.org/48413004/70001
7 years, 1 month ago (2013-10-29 17:03:03 UTC) #17
commit-bot: I haz the power
7 years, 1 month ago (2013-10-29 22:18:01 UTC) #18
Message was sent while issue was closed.
Change committed as 231652

Powered by Google App Engine
This is Rietveld 408576698