Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 484103002: [turbofan] Add TruncateFloat64ToInt32 machine operator. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add TruncateFloat64ToInt32 machine operator. Fix ChangeLowering to use TruncateFloat64ToInt32. TEST=cctest,compiler-unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23214

Patch Set 1 #

Patch Set 2 : Disable test-run-machops/RunTruncateFloat64ToInt32P on arm64. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -59 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/machine-node-factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +56 lines, -55 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 1 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M test/compiler-unittests/change-lowering-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/compiler-unittests/graph-unittest.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/compiler-unittests/graph-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/compiler-unittests/instruction-selector-unittest.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M test/compiler-unittests/machine-operator-unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
6 years, 4 months ago (2014-08-19 12:05:33 UTC) #1
Benedikt Meurer
Rodolph: We have to disable cctest/test-run-machops/RunTruncateFloat64ToInt32P on ARM64. Please take a look into fixing that ...
6 years, 4 months ago (2014-08-19 12:22:00 UTC) #2
Jarin
lgtm
6 years, 4 months ago (2014-08-19 19:15:19 UTC) #3
Benedikt Meurer
6 years, 4 months ago (2014-08-20 04:01:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as 23214 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698