Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 4841002: Disable FindInPageTest.PrepopulateRespectBlank (Closed)

Created:
10 years, 1 month ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Finnur
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable FindInPageTest.PrepopulateRespectBlank TBR=finnur BUG=62937 TEST=interactive_ui_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65927

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/find_bar_host_interactive_uitest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
10 years, 1 month ago (2010-11-12 10:33:56 UTC) #1
Finnur
I'm really disappointed with the level of detail here. The description of this changelist says ...
10 years, 1 month ago (2010-11-12 11:06:05 UTC) #2
Paweł Hajdan Jr.
10 years, 1 month ago (2010-11-12 11:09:11 UTC) #3
On Fri, Nov 12, 2010 at 12:06, <finnur@chromium.org> wrote:

> I remember in the past that the machines running interactive tests needed
> to be
> rebooted sometimes because they got wedged somehow. Have we investigated
> whether
> rebooting takes care of this problem, instead of just disabling tests?


This is from a scheduled Windows tryserver run. Afaik tryservers are
rebooted between each run.

I'm sorry about the useless log. I'd suggest adding some debugging info and
re-enabling the test.

Powered by Google App Engine
This is Rietveld 408576698