Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 484083003: Reland "Add initial support for inlining." (Closed)

Created:
6 years, 4 months ago by sigurds
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Add initial support for inlining." Reland Fixes: * Remove usage of C++11 vector members. * Guard tests by V8_TURBO_TARGET. Changes: * Make context specialization clean up after itself. * Add UpdateToAndIncrement to Inputs::iterator. Uses:iterator already provides this member function. * Allow next node id in graph to be set. R=titzer@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23231

Patch Set 1 #

Patch Set 2 : Add initial support for inlining. #

Patch Set 3 : Add initial support for inlining. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+609 lines, -53 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/generic-graph.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/generic-node.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 3 chunks +6 lines, -23 lines 0 comments Download
A src/compiler/js-inlining.h View 1 chunk +34 lines, -0 lines 0 comments Download
A src/compiler/js-inlining.cc View 1 2 1 chunk +329 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 3 chunks +7 lines, -28 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +22 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/compiler/test-run-inlining.cc View 1 2 1 chunk +184 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
6 years, 4 months ago (2014-08-19 15:06:15 UTC) #1
titzer
On 2014/08/19 15:06:15, sigurds wrote: lgtm
6 years, 4 months ago (2014-08-19 15:15:56 UTC) #2
sigurds
6 years, 4 months ago (2014-08-20 13:05:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as 23231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698