Use new operator consistently for constructor-like functions.

Use new operator consistently for constructor-like functions.

Function MainPanelScrollBar() is not a constructor, but it behaves like a constructor.
We can use new consistently for such functions.

BUG=none
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290741

[fukino, 2014-08-19 08:19:39]

@hirono - could you take a look?

Regarding to the http://bclary.com/2004/11/07/#a-13.2.2, the new isn't harmful
for a function returning an object, but it's confusing.

[hirono, 2014-08-19 08:58:18]

https://codereview.chromium.org/484083002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/file_grid.js (right):

https://codereview.chromium.org/484083002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/file_grid.js:46: self.scrollBar_ =
MainPanelScrollBar();
There is another confusion here. MainPanelScrollBar is constructor, and it is
called without new. In most cases, constructor call without new returns
undefined, so it looks a bug.

I'm fine with the previous version. WDYT?

[fukino, 2014-08-19 09:07:05]

On 2014/08/19 08:58:18, hirono wrote:
>
https://codereview.chromium.org/484083002/diff/1/ui/file_manager/file_manager...
> File ui/file_manager/file_manager/foreground/js/file_grid.js (right):
> 
>
https://codereview.chromium.org/484083002/diff/1/ui/file_manager/file_manager...
> ui/file_manager/file_manager/foreground/js/file_grid.js:46: self.scrollBar_ =
> MainPanelScrollBar();
> There is another confusion here. MainPanelScrollBar is constructor, and it is
> called without new. In most cases, constructor call without new returns
> undefined, so it looks a bug.
> 
> I'm fine with the previous version. WDYT?

If I read the cr.ui.define() correctly, MainPanelScrollBar() is not a
constructor, but a Function which returns an (created and decorated) element.
Actually, MainPanelScrollBar() is already called without new in
foreground/js/file_table.js and foreground/js/directory_tree.js...

[fukino, 2014-08-19 09:23:04]

On 2014/08/19 09:07:05, fukino wrote:
> On 2014/08/19 08:58:18, hirono wrote:
> >
>
https://codereview.chromium.org/484083002/diff/1/ui/file_manager/file_manager...
> > File ui/file_manager/file_manager/foreground/js/file_grid.js (right):
> > 
> >
>
https://codereview.chromium.org/484083002/diff/1/ui/file_manager/file_manager...
> > ui/file_manager/file_manager/foreground/js/file_grid.js:46: self.scrollBar_
=
> > MainPanelScrollBar();
> > There is another confusion here. MainPanelScrollBar is constructor, and it
is
> > called without new. In most cases, constructor call without new returns
> > undefined, so it looks a bug.
> > 
> > I'm fine with the previous version. WDYT?
> 
> If I read the cr.ui.define() correctly, MainPanelScrollBar() is not a
> constructor, but a Function which returns an (created and decorated) element.
> Actually, MainPanelScrollBar() is already called without new in
> foreground/js/file_table.js and foreground/js/directory_tree.js...

Oh, I misunderstood.
I agree with that it's better for us to view the MainPanelScrollBar() as a
constructor.
I modified our code to use new operator consistently, and I changed the
title/description of this CL.

[hirono, 2014-08-20 02:04:30]

lgtm. Thank you!

[fukino, 2014-08-20 02:24:42]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-08-20 02:26:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/fukino@chromium.org/484083002/20001

[commit-bot: I haz the power, 2014-08-20 03:28:29]

Committed patchset #2 (20001) as 290741